Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support verify client cert common name #747

Merged
merged 7 commits into from
Jul 18, 2020
Merged

*: support verify client cert common name #747

merged 7 commits into from
Jul 18, 2020

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Support verify client certification common name.

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • Support verify client certification common name.

@overvenus overvenus changed the title Support tls verify cn *: support verify client cert common name Jul 14, 2020
@DanielZhangQD DanielZhangQD mentioned this pull request Jul 15, 2020
Closed
6 tasks
@overvenus
*: support verify client cert common name
38a7f2b 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus marked this pull request as ready for review July 15, 2020 09:40
@overvenus overvenus added the component/status-server Status server component. label Jul 15, 2020
@overvenus
Copy link
Member Author

/run-integration-tests

@overvenus
Copy link
Member Author

/run-integration-tests

@overvenus
fix tests
1409b6b 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
Copy link
Member Author

/run-integration-tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2020 •
edited
Loading

Codecov Report

Merging #747 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #747   +/-   ##
===========================================
  Coverage   33.7824%   33.7824%           
===========================================
  Files            93         93           
  Lines         10242      10242           
===========================================
  Hits           3460       3460           
  Misses         6447       6447           
  Partials        335        335

@overvenus
refactor client cert check
3d13c2c 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
fix test
bdf9f5d 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
Copy link
Member Author

/ptal

@overvenus overvenus added the status/ptal Could you please take a look? label Jul 16, 2020
@zier-one
Copy link
Contributor

/lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 17, 2020
amyangfei
amyangfei reviewed Jul 17, 2020
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 17, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 17, 2020
@overvenus overvenus added this to the v4.0.4 milestone Jul 17, 2020
@overvenus
Copy link
Member Author

/merge

1 similar comment
@amyangfei
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 18, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@overvenus merge failed.

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 757

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 79a1d5b into pingcap:master Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@zier-one zier-one Awaiting requested review from zier-one

Assignees
No one assigned
Labels
component/status-server Status server component. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
v4.0.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@overvenus @codecov-commenter @zier-one @amyangfei @ti-srebot