owner: fix failed changefeed can't be removed #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
the
subject/usability
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
===========================================
Coverage 33.7054% 33.7054%
===========================================
Files 94 94
Lines 10482 10482
===========================================
Hits 3533 3533
Misses 6604 6604
Partials 345 345 |
|
/lgtm |
zier-one
approved these changes
Jul 27, 2020
ti-srebot
approved these changes
Jul 27, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
qinggniq
pushed a commit
to qinggniq/ticdc
that referenced
this pull request
Jul 28, 2020
* owner: fix failed changefeed can't be removed * add integration test * fix test case Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix bug in #766
What is changed and how it works?
collectChangefeedInfofunction, if error exists inChangefeedInfoand changefeed admin job type is notstoporremove, mark the changefeed asfailedfailedchangefeed viacdc cli changefeed removeCheck List
Tests
Release note