mounter: support more column flag #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 27, 2020 16:00
overvenus
reviewed
Jul 27, 2020
Co-authored-by: Neil Shen <overvenus@gmail.com>
added 2 commits
August 4, 2020 11:50
# Conflicts: # cdc/entry/mounter.go # cdc/model/sink.go
|
/run-integration-tests |
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #796 +/- ##
================================================
+ Coverage 32.3015% 32.5079% +0.2063%
================================================
Files 97 97
Lines 10758 10702 -56
================================================
+ Hits 3475 3479 +4
+ Misses 6945 6885 -60
Partials 338 338 |
|
/lgtm |
ti-srebot
approved these changes
Aug 4, 2020
amyangfei
added
the
release-blocker
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
blocked by #787
What is changed and how it works?
Check List
Tests
Release note