Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add dml batch callback duration metric in grafana #8134

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #5928

What is changed and how it works?

Add metric ticdc_sinkv2_txn_sink_dml_batch_callback in grafana template.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@amyangfei amyangfei added the area/ticdc Issues or PRs related to TiCDC. label Jan 30, 2023
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2023
@amyangfei amyangfei added the status/ptal Could you please take a look? label Jan 30, 2023
@3AceShowHand
Copy link
Contributor

/run-integration-test
/run-kafka-integration-test

@hi-rustin
Copy link
Member

@amyangfei Could you please post some screenshots to show it? Thanks!

@ti-chi-bot
Copy link
Member

@amyangfei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify b1cc289 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants