-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility of libzstd with different gcc version #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67f8650
to
fa2d09a
Compare
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
================================================
+ Coverage 32.3761% 32.3854% +0.0092%
================================================
Files 97 97
Lines 10761 10761
================================================
+ Hits 3484 3485 +1
+ Misses 6941 6940 -1
Partials 336 336 |
2d6df14
to
21a3b59
Compare
/run-integration-tests |
/lgtm |
/lgtm |
ti-srebot
approved these changes
Aug 11, 2020
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
This was referenced Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/test
Unit tests and integration tests component.
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
status/ptal
Could you please take a look?
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix CI warning
cdc.test: Symbol 'stderr' causes overflow in R_X86_64_PC32 relocation
Fix build failure with some GCC version, such as with `gcc version 9.3.0 (on Ubuntu 20.04.1 LTS)·
NOTE: this fix can be removed after we upgrade https://github.com/apache/pulsar-client-go to latest version
What is changed and how it works?
Compile
libzstd.a
based on https://github.com/valyala/gozstd#faqCheck List
Tests
Release note