Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility of libzstd with different gcc version #834

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Aug 11, 2020

What problem does this PR solve?

  • Fix CI warning cdc.test: Symbol 'stderr' causes overflow in R_X86_64_PC32 relocation

  • Fix build failure with some GCC version, such as with `gcc version 9.3.0 (on Ubuntu 20.04.1 LTS)·

/home/apple/.gvm/gos/go1.14.6/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
/usr/bin/ld: /home/apple/.gvm/pkgsets/go1.14.6/global/pkg/mod/github.com/valyala/gozstd@v1.7.0/libzstd_linux_amd64.a(zdict.o): relocation R_X86_64_PC32 against symbol `stderr@@GLIBC_2.2.5' can not be used when making a PDE object; recompile with -fPIE
/usr/bin/ld: final link failed: bad value
collect2: error: ld returned 1 exit status

NOTE: this fix can be removed after we upgrade https://github.com/apache/pulsar-client-go to latest version

What is changed and how it works?

Compile libzstd.a based on https://github.com/valyala/gozstd#faq

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@amyangfei amyangfei added the component/test Unit tests and integration tests component. label Aug 11, 2020
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2020

Codecov Report

Merging #834 into master will increase coverage by 0.0093%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master       #834        +/-   ##
================================================
+ Coverage   32.3761%   32.3854%   +0.0092%     
================================================
  Files            97         97                
  Lines         10761      10761                
================================================
+ Hits           3484       3485         +1     
+ Misses         6941       6940         -1     
  Partials        336        336                

@amyangfei
Copy link
Contributor Author

/run-integration-tests

@amyangfei amyangfei added the status/ptal Could you please take a look? label Aug 11, 2020
@overvenus
Copy link
Member

/lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2020
@zier-one
Copy link
Contributor

/lgtm

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 11, 2020
@zier-one
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 831
  • 833

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Unit tests and integration tests component. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants