Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema, sink(ticdc): fix exchange partition #8955

Merged
merged 2 commits into from May 15, 2023
Merged

schema, sink(ticdc): fix exchange partition #8955

merged 2 commits into from May 15, 2023

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented May 11, 2023 •
edited

What problem does this PR solve?

Issue Number: close #8914

What is changed and how it works?

  1. Store source tableInfo in ddl.PreTableInfo.
  2. Write table def to source table directory.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 11, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 11, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 11, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2023
@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review May 15, 2023 08:02
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2023
@CharlesCheung96 CharlesCheung96 requested review from asddongmen and hi-rustin and removed request for asddongmen May 15, 2023 08:02
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 15, 2023
@CharlesCheung96
Copy link
Contributor Author

/test cdc-integration-storage-test

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 15, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 15, 2023
@CharlesCheung96
Copy link
Contributor Author

/run check-issue-triage-complete

@CharlesCheung96
Copy link
Contributor Author

/test check-issue-triage-complete

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 15, 2023

@CharlesCheung96: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test cdc-integration-kafka-test
  • /test cdc-integration-mysql-test
  • /test cdc-integration-storage-test
  • /test dm-compatibility-test
  • /test dm-integration-test
  • /test engine-integration-test
  • /test verify

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tiflow/ghpr_verify

In response to this:

/test check-issue-triage-complete

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CharlesCheung96
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 15, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 3ef1485

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 15, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@CharlesCheung96
Copy link
Contributor Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels May 15, 2023
@nongfushanquan
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 03285b8 into pingcap:master May 15, 2023
14 of 16 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request May 15, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8961.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 15, 2023
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#8955
908a56d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 15, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8962.

ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2023
@ti-chi-bot
schema, sink(ticdc): fix exchange partition (#8955) (#8962)
ca9c4e2 
close #8914
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request May 18, 2023
@CharlesCheung96
schema, sink(ticdc): fix exchange partition (pingcap#8955)
7c321bf 
close pingcap#8914
ti-chi-bot bot pushed a commit that referenced this pull request May 18, 2023
@ti-chi-bot
schema, sink(ticdc): fix exchange partition (#8955) (#8961)
ce6feaa 
close #8914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@hi-rustin hi-rustin Awaiting requested review from hi-rustin

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make storage sink support exchange partition
4 participants
@CharlesCheung96 @nongfushanquan @ti-chi-bot @asddongmen