Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker(dm): handle expression UNIQUE index #9353

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #9247

What is changed and how it works?

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jul 6, 2023
@lance6716 lance6716 requested review from okJiang and GMHDBJD July 6, 2023 06:14
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 6, 2023
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-06 06:52:03.722697392 +0000 UTC m=+4402.604173339: ☑️ agreed by okJiang.
  • 2023-07-07 03:59:13.735908372 +0000 UTC m=+45245.506247085: ☑️ agreed by GMHDBJD.

@lance6716
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
@lance6716
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit 53d4893 into pingcap:master Jul 7, 2023
13 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9362.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 7, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9363.

ti-chi-bot bot pushed a commit that referenced this pull request Jul 13, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dm panic due to empty column name of unique index
4 participants