Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p(ticdc): fix panic issue when peer is not found #9355

Merged
merged 1 commit into from Jul 7, 2023

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Jul 6, 2023

What problem does this PR solve?

Issue Number: close #9354

What is changed and how it works?

fix panic issue when peer is not found

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 6, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-06 10:12:34.316700168 +0000 UTC m=+16433.198176112: ☑️ agreed by 3AceShowHand.
  • 2023-07-06 10:23:13.303726192 +0000 UTC m=+17072.185202139: ☑️ agreed by asddongmen.

@sdojjy
Copy link
Member Author

sdojjy commented Jul 6, 2023

/test verify

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023
@sdojjy
Copy link
Member Author

sdojjy commented Jul 7, 2023

/test all

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
@sdojjy
Copy link
Member Author

sdojjy commented Jul 7, 2023

/retest-required

1 similar comment
@sdojjy
Copy link
Member Author

sdojjy commented Jul 7, 2023

/retest-required

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit 7b4c270 into pingcap:master Jul 7, 2023
14 of 16 checks passed
@sdojjy sdojjy deleted the fix-panic-issue-when-remove-peer branch July 7, 2023 14:21
@sdojjy sdojjy added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Aug 2, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9475.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix panic issue if peer not found
4 participants