Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner: fix mem leak in changefeed #942

Merged
merged 4 commits into from
Sep 10, 2020
Merged

owner: fix mem leak in changefeed #942

merged 4 commits into from
Sep 10, 2020

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented Sep 9, 2020

What problem does this PR solve?

fix mem leak in changefeed

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

@zier-one zier-one mentioned this pull request Sep 9, 2020
Closed
@zier-one zier-one added this to the v4.0.6 milestone Sep 9, 2020
@zier-one zier-one added status/ptal Could you please take a look? release-blocker This issue blocks a release. Please solve it ASAP. type/bugfix This PR fixes a bug. labels Sep 9, 2020
overvenus
overvenus reviewed Sep 9, 2020
View reviewed changes
cdc/owner.go Outdated Show resolved Hide resolved
amyangfei
amyangfei reviewed Sep 10, 2020
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 10, 2020
@overvenus
Copy link
Member

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 10, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 10, 2020
@amyangfei
Copy link
Contributor

/run-all-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

1 similar comment
@amyangfei
Copy link
Contributor

/run-all-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

@codecov-commenter
Copy link

Codecov Report

Merging #942 into master will increase coverage by 0.2663%.
The diff coverage is 38.0228%.

@@               Coverage Diff                @@
##             master       #942        +/-   ##
================================================
+ Coverage   33.1031%   33.3694%   +0.2663%     
================================================
  Files            99        100         +1     
  Lines         11872      11987       +115     
================================================
+ Hits           3930       4000        +70     
- Misses         7553       7594        +41     
- Partials        389        393         +4

@zier-one zier-one merged commit dbe15ee into pingcap:master Sep 10, 2020
@zier-one zier-one deleted the fix_mem_leak branch September 10, 2020 09:29
This was referenced Aug 24, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei left review comments

@overvenus overvenus overvenus left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
v4.0.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zier-one @overvenus @amyangfei @codecov-commenter @ti-srebot