Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql(ticdc): use string join to build multi statement sql. #9936

Merged
merged 2 commits into from Oct 20, 2023

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Oct 20, 2023

What problem does this PR solve?

Issue Number: close #9935

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

img_v2_2ab5f26b-4406-45b3-ae75-0d66cf9fc49g

The memory cost reduced significantly

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 20, 2023
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 20, 2023
@3AceShowHand 3AceShowHand added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Oct 20, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-20 08:13:36.732973288 +0000 UTC m=+1990414.320083425: ☑️ agreed by asddongmen.
  • 2023-10-20 08:19:12.872480943 +0000 UTC m=+1990750.459591080: ☑️ agreed by nongfushanquan.

@3AceShowHand 3AceShowHand changed the title mysql(ticdc): use string builder to build multi statement sql. mysql(ticdc): use string join to build multi statement sql. Oct 20, 2023
@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-kafka-test

@ti-chi-bot ti-chi-bot bot merged commit e4ac90b into pingcap:master Oct 20, 2023
14 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9937.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9938.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9939.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mysql sink allocate a huge number of memory when build multi statement sql.
5 participants