Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raftstore: notify pd when leader ship changes #1658

Merged
merged 2 commits into from
Mar 3, 2017
Merged

raftstore: notify pd when leader ship changes #1658

merged 2 commits into from
Mar 3, 2017

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Feb 27, 2017

siddontang
siddontang approved these changes Feb 27, 2017
View reviewed changes
Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siddontang
Copy link
Contributor

PTAL @hhkbp2 @disksing

@BusyJay
Copy link
Member Author

BusyJay commented Mar 1, 2017

PTAL

@siddontang
Copy link
Contributor

Ping @disksing @hhkbp2

@disksing
Copy link
Contributor

disksing commented Mar 3, 2017 •
edited
Loading

LGTM.
I've tested this branch on a 10 nodes cluster which contains about 9k regions. Compare to RC2 branch, the leader balance time after restarting all nodes decreases about 50%.

@BusyJay BusyJay merged commit 5c8afee into master Mar 3, 2017
@BusyJay BusyJay deleted the busyjay/notify-leader branch March 3, 2017 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddontang siddontang siddontang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BusyJay @siddontang @disksing