Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: add more util methods #2100

Merged
merged 4 commits into from Aug 1, 2017
Merged

config: add more util methods #2100

merged 4 commits into from Aug 1, 2017

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Jul 28, 2017

  • add serde methods for compression type arrays instead of compression type
  • add serde methods for ordermap
  • add helper methods for readable types

@BusyJay BusyJay force-pushed the busyjay/add-more-serde branch 3 times, most recently from c3de8f0 to 6f6722b Compare July 29, 2017 13:56
siddontang
siddontang reviewed Jul 31, 2017
View reviewed changes
src/util/config.rs
}
}

pub mod order_map_serde {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a map field for the configuration?

Copy link
Member Author

@BusyJay BusyJay Jul 31, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, store labels for example.

@BusyJay
Copy link
Member Author

BusyJay commented Jul 31, 2017

PTAL

overvenus
overvenus approved these changes Jul 31, 2017
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siddontang
Copy link
Contributor

LGTM

The config file is too large, I suggest using a config directory and split the file.

@BusyJay
Copy link
Member Author

BusyJay commented Aug 1, 2017

A lot of codes will be deleted once configuration refactoring is finished.

@BusyJay BusyJay merged commit 027c864 into master Aug 1, 2017
@BusyJay BusyJay deleted the busyjay/add-more-serde branch August 1, 2017 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddontang siddontang siddontang left review comments

@overvenus overvenus overvenus approved these changes

@andelf andelf Awaiting requested review from andelf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BusyJay @siddontang @overvenus