-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: add more util methods #2100
Conversation
BusyJay
commented
Jul 28, 2017
- add serde methods for compression type arrays instead of compression type
- add serde methods for ordermap
- add helper methods for readable types
c3de8f0
to
6f6722b
Compare
6f6722b
to
56c4ba3
Compare
} | ||
} | ||
|
||
pub mod order_map_serde { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a map field for the configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, store labels for example.
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM The config file is too large, I suggest using a config directory and split the file. |
A lot of codes will be deleted once configuration refactoring is finished. |