Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copr: adjust decimal parsing interface #2232

Merged
merged 7 commits into from Sep 1, 2017
Merged

copr: adjust decimal parsing interface #2232

merged 7 commits into from Sep 1, 2017

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Aug 30, 2017

So when calling from_bytes, no utf8 validation is performed.

AndreMouche
AndreMouche reviewed Aug 31, 2017
View reviewed changes
Copy link
Member

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hicqu
Copy link
Contributor

hicqu commented Aug 31, 2017

LGTM.

@BusyJay BusyJay merged commit 3da148f into master Sep 1, 2017
@BusyJay BusyJay deleted the busyjay/use-bytes-by-default branch September 1, 2017 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMouche AndreMouche AndreMouche left review comments

@hicqu hicqu hicqu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BusyJay @hicqu @AndreMouche