coprocessor/statistics: implement count-min sketch #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Ping @hanfei1991 @winoros |
hanfei1991
reviewed
Nov 16, 2017
| /// the result set using Reservoir Sampling algorithm, and estimates NDVs | ||
| /// using FM Sketch during the collecting process. | ||
| /// the result set using Reservoir Sampling algorithm, estimates NDVs | ||
| /// using FM Sketch during the collecting process, and build count-min sketch. |
| ) | ||
| } | ||
|
|
||
| pub fn insert(&mut self, bytes: &[u8]) { |
There was a problem hiding this comment.
This function is not easy to read, please add some comment.
| } | ||
| } | ||
|
|
||
| fn hash(mut bytes: &[u8]) -> (u64, u64) { |
|
rest LGTM |
|
LGTM |
|
PTAL @AndreMouche @winoros |
|
Please fix the conflict Ping @winoros |
|
Do we have tests that intergrated tidb with tikv? |
|
@winoros Yes. |
AndreMouche
reviewed
Nov 27, 2017
| use coprocessor::codec::datum; | ||
| use coprocessor::codec::datum::Datum; | ||
| use util::as_slice; | ||
| use std::collections::HashMap; |
There was a problem hiding this comment.
Please reorder crate according to the following order:
- std
- third party crate
- crate in current project
- supper
|
/run-all-tests |
AndreMouche
approved these changes
Nov 27, 2017
|
/run-all-tests |
Gamrix
pushed a commit
to Gamrix/tikv_bft
that referenced
this pull request
Nov 29, 2017
Gamrix
added a commit
to Gamrix/tikv_bft
that referenced
this pull request
Nov 29, 2017
This reverts commit 89c2d5c.
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL @hanfei1991 @winoros @AndreMouche