Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rocksdb release 5.8 #2543

Merged
merged 5 commits into from
Dec 2, 2017
Merged

Conversation

zhangjinpeng87
Copy link
Member

No description provided.

@zhangjinpeng87
Copy link
Member Author

/run-all-tests

circle.yml Outdated
@@ -67,5 +67,5 @@ dependencies:

test:
override:
- cargo test --features "dev" -- --nocapture
- cargo test --features "dev" -- --nocapture --verbose
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need verbose here?

Copy link
Member Author

@zhangjinpeng87 zhangjinpeng87 Dec 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With verbose we will know the exact fail reason. If don't set verbose, sometimes we will get "exit 101 with unknown reason" error message, but with verbose, we will get " received signal SIGSEGV, Segmentation fault" error message.

@huachaohuang
Copy link
Contributor

LGTM

Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut merged commit bd02cf6 into tikv:master Dec 2, 2017
@zhangjinpeng87 zhangjinpeng87 deleted the upgrade-to-rocksdb-5.8 branch December 6, 2017 06:26
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
* use rocksdb release 5.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants