fix cleanup for raw kv #2724
Merged
fix cleanup for raw kv #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siddontang @BusyJay PTAL |
siddontang
reviewed
Jan 30, 2018
src/util/rocksdb/mod.rs
Outdated
| @@ -317,26 +333,14 @@ pub fn roughly_cleanup_range(db: &DB, start_key: &[u8], end_key: &[u8]) -> Resul | |||
| return Ok(()); | |||
| } | |||
|
|
|||
| // Todo: use end_key directly after delete_files_in_range support [start, end) semantics. | |||
| let end = prev_key(end_key).unwrap(); | |||
|
Rest LGTM PTAL @huachaohuang |
src/util/rocksdb/mod.rs
Outdated
| @@ -317,26 +333,14 @@ pub fn roughly_cleanup_range(db: &DB, start_key: &[u8], end_key: &[u8]) -> Resul | |||
| return Ok(()); | |||
| } | |||
|
|
|||
| // Todo: use end_key directly after delete_files_in_range support [start, end) semantics. | |||
| let end = prev_key(end_key).unwrap(); | |||
| if end.as_slice() >= start_key { | |||
There was a problem hiding this comment.
start_key >= end.as_slice()?
huachaohuang
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keys in raw KV scenario don't have ts tail, in that situation we can't use region's
end_keyto involvedelete_files_in_range.