Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO list after normalize pdclient to client-java #2521

Closed
yegetables opened this issue Aug 24, 2022 · 5 comments
Closed

TODO list after normalize pdclient to client-java #2521

yegetables opened this issue Aug 24, 2022 · 5 comments

Comments

@yegetables
Copy link
Contributor

yegetables commented Aug 24, 2022

  • com.pingcap.tikv.util.ConvertUpstreamUtils.isTiKVVersionGreatEqualThanVersion method: If the upstream changes the method name from StoreVersion.minTiKVVersion to StoreVersion.isTiKVVersionGreatEqualThanVersion, remove this method and use the upstream method directly. change method name StoreVersion.minTiKVVersion to StoreVersion.isTi… tikv/client-java#647

  • TiDBOptions txnPrewriteBatchSize,txnCommitBatchSize,writeBufferSize,writeThreadPerTask,retryCommitSecondaryKey,prewriteMaxRetryTimes are deleted, because these configuration items involve the private constructor of TwoPhaseCommitter. Upstream does not provide a public constructor for use. Temporarily disable the settings of several configuration items to restore the upstream updated configuration. (recovery of documents involved).

  • TiFlash cache missing need to fix. [TISPARK-488] Fix TiFlash region cache  #1380 Temporarily fixed in TiSpark.

  • If the retry logic of batchGet is added upstream. Re-check the test result of batchGetRetryTest. Restore the test or modify/delete the test [fix #643] fix retry with resolvedlocks info tikv/client-java#645

According to the removed class by #2491, the following prs need to be paid attention to. we need to judge if they are needed to port to upstream.
image

@shiyuhang0
Copy link
Member

shiyuhang0 commented Dec 13, 2022

TiFlash cache missing needs to fix. [TISPARK-488] Fix TiFlash region cache #1380 Temporarily fixed in TiSpark

If the retry logic of batchGet is added upstream. Re-check the test result of batchGetRetryTest. Restore the test or modify/delete the test tikv/client-java#645

Fix region manager race: #1987. (seems has done in client-java)
Optimize region cache miss:#2106 + fix not leader error due to region not invalidatedhttps://github.com/#2135

fix region may be missed: #2433

support log desensitization: #1798

Fix ResolveLock not called in Scan API #2089

Make TiSpark's Explain clearer and easier to read: #2439
support clustered index #1915 ( maintain CoprocessorIterator in TiSpark or upstream ?)
Fix txnHeartBeat retry: #2304
retry enhancement: #1768 #2279

  • need not port

@shiyuhang0
Copy link
Member

shiyuhang0 commented Dec 16, 2022

Sometimes, it is difficult to judge which is better (TiSpark or client-java), for example, return null or throw an exception; whether retry for a certain error
In such case, here are two suggestions:

  • follow the behavior of TiDB
  • reference client-go

@yegetables
Copy link
Contributor Author

有时候,很难判断哪个更好(TiSpark或者client-java),比如返回null或者抛出异常;是否为某个错误重试 这种情况,这里有两个建议:

  • 随行 TiDB 的行为
  • 参考客户端

The previous integration test table was not found whether it was caused by a cache miss

I found that the integration test on jenkins seems to be refactored once? (curious)

@shiyuhang0
Copy link
Member

table not found may not result from the cache miss. it supposed to be fixed in this pr tikv/client-java#670.

integration test should not be refactored.

@shiyuhang0
Copy link
Member

shiyuhang0 commented Dec 26, 2022

All things have been done or a corresponding issue has been opend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants