Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TiSpark's Explain clearer and easier to read #2439

Merged
merged 46 commits into from Jul 20, 2022
Merged

Make TiSpark's Explain clearer and easier to read #2439

merged 46 commits into from Jul 20, 2022

Conversation

qidi1
Copy link
Contributor

@qidi1 qidi1 commented Jul 1, 2022 •
edited by xuanyu66

What problem does this PR solve?

make explain in TiSpark more clear
proposal: #2385

qidi1 added 2 commits July 1, 2022 09:27
@qidi1
change string() in TiDAGRequest
8742286 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
change name of scan
0ba3dd5 
Signed-off-by: qidi1 <1083369179@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 1, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shiyuhang0
  • xuanyu66

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@qidi1 qidi1 mentioned this pull request Jul 1, 2022
Closed
@shiyuhang0
Copy link
Member

shiyuhang0 commented Jul 1, 2022 •
edited

plz fix the action

qidi1 added 2 commits July 1, 2022 14:37
@qidi1
merge master
d8fe1c8 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
repaire test error
f04abcb 
Signed-off-by: qidi1 <1083369179@qq.com>
qidi1 added 2 commits July 1, 2022 15:55
@qidi1
format code
dcdae3c 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
repair word error
46cb114 
Signed-off-by: qidi1 <1083369179@qq.com>
shiyuhang0
shiyuhang0 reviewed Jul 1, 2022
View reviewed changes
config/tidb.toml Outdated Show resolved Hide resolved
@shiyuhang0
Copy link
Member

you need to add a doc for this feature

@qidi1
repair test error
4441c17 
Signed-off-by: qidi1 <1083369179@qq.com>
qidi1 added 4 commits July 4, 2022 11:23
@qidi1
add doc of execution plan in tispark
9a38567 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
add github action of alter primary key false
0a508cf 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
set alter-primary-key true
e637e81 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
delete mutit jdk
41dc92b 
Signed-off-by: qidi1 <1083369179@qq.com>
shiyuhang0
shiyuhang0 reviewed Jul 4, 2022
View reviewed changes
.github/workflows/alter-primary-key-false-test.yml Outdated Show resolved Hide resolved
.github/workflows/alter-primary-key-false-test.yml Outdated Show resolved Hide resolved
docs/query_execution_plan_in_TiSpark.md Outdated Show resolved Hide resolved
docs/query_execution_plan_in_TiSpark.md Show resolved Hide resolved
docs/query_execution_plan_in_TiSpark.md Show resolved Hide resolved
qidi1 added 4 commits July 4, 2022 15:46
@qidi1
repaire TLS test
bdf1a42 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
empty line in alter-primary-key-false-test.yml
1479efe 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
delete delete-test in alter-primary-key-false-test.yml
ff3bdff 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
change doc
fca8686 
Signed-off-by: qidi1 <1083369179@qq.com>
@xuanyu66
Copy link
Collaborator

/run-all-tests

@qidi1
repaire bug
fa70f87 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
Copy link
Contributor Author

qidi1 commented Jul 18, 2022

/run-all-tests

3 similar comments
@qidi1
Copy link
Contributor Author

qidi1 commented Jul 18, 2022

/run-all-tests

@qidi1
Copy link
Contributor Author

qidi1 commented Jul 18, 2022

/run-all-tests

@qidi1
Copy link
Contributor Author

qidi1 commented Jul 18, 2022

/run-all-tests

@qidi1
repaire bug
3d9d4d0 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
Copy link
Contributor Author

qidi1 commented Jul 19, 2022

/run-all-tests

@qidi1
repaire bug
ee6a767 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
Copy link
Contributor Author

qidi1 commented Jul 19, 2022

/run-all-tests

@shiyuhang0
Copy link
Member

/run-all-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

@qidi1
repaire bug
dce8c31 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
Copy link
Contributor Author

qidi1 commented Jul 19, 2022

/run-all-tests

@qidi1
Copy link
Contributor Author

qidi1 commented Jul 19, 2022

/run-all-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

@xuanyu66
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dce8c31

@ti-chi-bot ti-chi-bot merged commit 058d58e into pingcap:master Jul 20, 2022
@qidi1 qidi1 deleted the phyicalplanexplain branch July 20, 2022 04:29
@shiyuhang0 shiyuhang0 mentioned this pull request Aug 25, 2022
Closed
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@qidi1
Make TiSpark's Explain clearer and easier to read (pingcap#2439)
86bc504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangyangyu zhangyangyu zhangyangyu left review comments

@xuanyu66 xuanyu66 xuanyu66 approved these changes

@Daemonxiao Daemonxiao Daemonxiao approved these changes

@shiyuhang0 shiyuhang0 shiyuhang0 approved these changes

Assignees
No one assigned
Labels
status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@qidi1 @ti-chi-bot @shiyuhang0 @xuanyu66 @zhangyangyu @Daemonxiao