Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix String type push down #1500

Merged
merged 1 commit into from Jul 2, 2020
Merged

Fix String type push down #1500

merged 1 commit into from Jul 2, 2020

Conversation

birdstorm
Copy link
Contributor

@birdstorm birdstorm commented Jul 1, 2020 •
edited

What problem does this PR solve?

Close #1498
String type push down was accidentally disabled in #1391

What is changed and how it works?

Fix it by enabling push down for strings.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

marsishandsome
marsishandsome approved these changes Jul 1, 2020
View reviewed changes
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm
Copy link
Contributor Author

/run-integration-tests

2 similar comments
@birdstorm
Copy link
Contributor Author

/run-integration-tests

@birdstorm
Copy link
Contributor Author

/run-integration-tests

@birdstorm birdstorm merged commit 68c85fb into pingcap:master Jul 2, 2020
@birdstorm birdstorm deleted the fix-string-type-pushdown branch July 2, 2020 05:00
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@birdstorm
fix string type pushdown (pingcap#1500)
af09d57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsishandsome marsishandsome marsishandsome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] TiSpark 2.3 does not use correct plan for IndexScan
2 participants
@birdstorm @marsishandsome