fix region may be missed (#2433) #2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
xuanyu66
approved these changes
Jul 1, 2022
Daemonxiao
approved these changes
Jul 1, 2022
|
/run-all-tests |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: fd870e7
|
shiyuhang0
approved these changes
Jul 11, 2022
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2433
What problem does this PR solve?
close #2368
When TiDB has more than 10,000 tables in one Database, TiSpark may throw Table not found exceptions.
What is changed and how it works?
The problem reported by the issue is caused by not timely update of region.
When there have stale data in region cache, the iterator will use end key in stale region to scan regions, and it may miss some new regions. And if we try to read the table in new region, table not found exceptions will be thrown.
In fact, RegionStoreClient has already gotten the new region, but doesn't send it to ConcreteScanIterator. So we add the code to update region.
Check List
Tests