Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPL fix (#2457) #2461

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2457

What problem does this PR solve?

If mysql-connector-J with the GPL license is included, then the license of TiSpark will also be polluted as GPL

What is changed and how it works?

upgrade mysql-connector-java from 5.1.49 to 8.0.29 and remove it from the TiSpark'jar to avoid GPL pollution.

Btw, change little tests to be compatible with the upgraded mysql-connector-java.

doc: https://github.com/pingcap/tispark/wiki/Getting-TiSpark#getting-mysql-connector-j

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

  • pom changed
  • some test changed

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 20, 2022
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shiyuhang0
  • xuanyu66

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@shiyuhang0
Copy link
Member

/run-all-tests

@shiyuhang0
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 04fb397

@ti-chi-bot ti-chi-bot merged commit 05e22d1 into pingcap:release-2.5 Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants