Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix count/avg push down (#2445) #2469

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2445

What problem does this PR solve?

close #2313
#1840
close #1142

What is changed and how it works?

this bug is simply fixed by push down Constant(1) when count(1) or count(*)

  • push down count by add pattern match for count, but
    • count(set) will not be pushed down because tikv can't accpect set type.
    • count(col1,col2,...) will not be pushed down because TiKV can't accpect (TIDB not support it)
  • push down Constant(1) when count(1) or count(*)
  • rewrite test and add test for count/avg

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 25, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shiyuhang0
  • xuanyu66

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@shiyuhang0
Copy link
Member

/run-all-tests

@shiyuhang0
Copy link
Member

/run-all-tests

@shiyuhang0
Copy link
Member

/run-all-tests

@xuanyu66
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: e80c744

@ti-chi-bot ti-chi-bot merged commit 2d39803 into pingcap:release-2.5 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants