Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: exception when the size of pdAddresse is > 1 (#2473) #2477

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2473

What problem does this PR solve?

When config with multi pdAddresses, telemetry throw exception
origin_img_v2_ce4f41f6-749e-44bb-adc6-9f5061e67e7g

What is changed and how it works?

  • Make the telemetry work with multi pdAddresses
  • Make the auth work with multi pdAddresses

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    tiup cluster start 2 pd nodes, and run the tests

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Daemonxiao
  • shiyuhang0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@xuanyu66
Copy link
Collaborator

xuanyu66 commented Aug 2, 2022

/run-all-tests

@xuanyu66
Copy link
Collaborator

xuanyu66 commented Aug 2, 2022

/run-all-tests

1 similar comment
@xuanyu66
Copy link
Collaborator

xuanyu66 commented Aug 2, 2022

/run-all-tests

@xuanyu66
Copy link
Collaborator

xuanyu66 commented Aug 2, 2022

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 9c93aba

@ti-chi-bot ti-chi-bot merged commit 0d3901c into pingcap:release-2.5 Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants