Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix break change in parititon read #2552

Merged
merged 3 commits into from Sep 22, 2022
Merged

Fix break change in parititon read #2552

merged 3 commits into from Sep 22, 2022

Conversation

xuanyu66
Copy link
Collaborator

@xuanyu66 xuanyu66 commented Sep 22, 2022 •
edited

What problem does this PR solve?

Partition Read has a breaking change.
image

What is changed and how it works?

Use different logic in partition read and write.

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 22, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shiyuhang0
  • zhangyangyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@xuanyu66 xuanyu66 added the needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 label Sep 22, 2022
@xuanyu66
Copy link
Collaborator Author

/run-all-tests

@xuanyu66
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9eae307

@shiyuhang0
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot merged commit 37e2424 into master Sep 22, 2022
@ti-srebot
Copy link
Collaborator

cherry pick to release-release failed

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 22, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2553.

ti-chi-bot added a commit that referenced this pull request Sep 22, 2022
@ti-chi-bot
Fix break change in parititon read (#2552) (#2553)
0199073
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@xuanyu66
Fix break change in parititon read (pingcap#2552)
244267f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangyangyu zhangyangyu zhangyangyu approved these changes

@shiyuhang0 shiyuhang0 shiyuhang0 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xuanyu66 @ti-chi-bot @shiyuhang0 @ti-srebot @zhangyangyu