Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement CBO #2563

Merged
merged 11 commits into from Oct 14, 2022
Merged

Enhancement CBO #2563

merged 11 commits into from Oct 14, 2022

Conversation

shiyuhang0
Copy link
Member

@shiyuhang0 shiyuhang0 commented Oct 12, 2022 •
edited

What problem does this PR solve?

After this PR, TiSpark will choose the store according to the min cost between tikv table scan, tikv index scan and tifalsh scan.

Before this pr, TiSpark only compare tikv table scan and tiflash scan, and usually choose tiflash once the table has tiflash replica.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 12, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Daemonxiao
  • xuanyu66

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/run-all-tests test-flash=true

@shiyuhang0 shiyuhang0 added needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4 needs-cherry-pick-release-2.5 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.0 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 labels Oct 12, 2022
@shiyuhang0
Copy link
Member Author

/run-all-tests test-flash=true

@shiyuhang0
Copy link
Member Author

/run-all-tests

shiyuhang0 and others added 2 commits October 13, 2022 13:00
@shiyuhang0 @xuanyu66
Update tikv-client/src/main/java/com/pingcap/tikv/predicates/TiKVScan…
f5e8b65 
…Analyzer.java

Co-authored-by: Leon Yang <yangxin@pingcap.com>
@shiyuhang0 @xuanyu66
Update tikv-client/src/main/java/com/pingcap/tikv/predicates/TiKVScan…
fd2fa00 
…Analyzer.java

Co-authored-by: Leon Yang <yangxin@pingcap.com>
shiyuhang0 and others added 4 commits October 13, 2022 14:01
@shiyuhang0 @Daemonxiao
Update tikv-client/src/main/java/com/pingcap/tikv/predicates/TiKVScan…
fb506d9 
…Analyzer.java

Co-authored-by: Daemonxiao <35677990+Daemonxiao@users.noreply.github.com>
@shiyuhang0 @Daemonxiao
Update tikv-client/src/main/java/com/pingcap/tikv/predicates/TiKVScan…
25b564b 
…Analyzer.java

Co-authored-by: Daemonxiao <35677990+Daemonxiao@users.noreply.github.com>
@shiyuhang0 @Daemonxiao
Update tikv-client/src/main/java/com/pingcap/tikv/predicates/TiKVScan…
90f7b3e 
…Analyzer.java

Co-authored-by: Daemonxiao <35677990+Daemonxiao@users.noreply.github.com>
@shiyuhang0 @Daemonxiao
Update tikv-client/src/main/java/com/pingcap/tikv/predicates/TiKVScan…
b33b70e 
…Analyzer.java

Co-authored-by: Daemonxiao <35677990+Daemonxiao@users.noreply.github.com>
@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b33b70e

@ti-chi-bot ti-chi-bot merged commit b1feaa3 into pingcap:master Oct 14, 2022
@ti-srebot
Copy link
Collaborator

cherry pick to release-release failed

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 14, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2566.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Oct 14, 2022
@shiyuhang0 @ti-chi-bot
This is an automated cherry-pick of pingcap#2563
f7ca662 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 14, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2567.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Oct 14, 2022
@shiyuhang0 @ti-chi-bot
This is an automated cherry-pick of pingcap#2563
bff12ca 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 14, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2568.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 14, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2569.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Oct 14, 2022
@shiyuhang0 @ti-chi-bot
This is an automated cherry-pick of pingcap#2563
413d807 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Oct 20, 2022
@ti-chi-bot
Enhancement CBO (#2563) (#2568)
d71f393
ti-chi-bot added a commit that referenced this pull request Oct 20, 2022
@ti-chi-bot
Enhancement CBO (#2563) (#2566)
e6fd049
ti-chi-bot added a commit that referenced this pull request Oct 25, 2022
@ti-chi-bot
Enhancement CBO (#2563) (#2567)
d9f9d92
ti-chi-bot added a commit that referenced this pull request Oct 25, 2022
@ti-chi-bot
Enhancement CBO (#2563) (#2569)
1e39497
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@shiyuhang0
Enhancement CBO (pingcap#2563)
41fbc95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuanyu66 xuanyu66 xuanyu66 approved these changes

@Daemonxiao Daemonxiao Daemonxiao approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4 needs-cherry-pick-release-2.5 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.0 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shiyuhang0 @ti-chi-bot @ti-srebot @xuanyu66 @Daemonxiao