Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partition write support new collations #2565

Merged
merged 10 commits into from Oct 14, 2022
Merged

Partition write support new collations #2565

merged 10 commits into from Oct 14, 2022

Conversation

xuanyu66
Copy link
Collaborator

@xuanyu66 xuanyu66 commented Oct 12, 2022 •
edited

What problem does this PR solve?

In #2524, TiSpark supports new collation.
According to Range column partition, partitioning also needs to obey the sort orders of collation.

What is changed and how it works?

  • For range column partition, using different sort orders according to collation

Check List

Tests

  • Integration test

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 12, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Daemonxiao
  • shiyuhang0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@xuanyu66
Copy link
Collaborator Author

/run-all-tests

github-actions[bot]
github-actions bot reviewed Oct 12, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 484 files.

Valid Invalid Ignored Fixed
482 2 0 0
Click to see the invalid file list
  • core/src/test/scala/com/pingcap/tispark/partition/PartitionBaseSuite.scala
  • core/src/test/scala/com/pingcap/tispark/partition/PartitionNewCollationSuite.scala

github-actions[bot]
github-actions bot reviewed Oct 12, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 484 files.

Valid Invalid Ignored Fixed
482 2 0 0
Click to see the invalid file list
  • core/src/test/scala/com/pingcap/tispark/partition/PartitionBaseSuite.scala
  • core/src/test/scala/com/pingcap/tispark/partition/PartitionNewCollationSuite.scala

core/src/test/scala/com/pingcap/tispark/partition/PartitionBaseSuite.scala Show resolved Hide resolved
core/src/test/scala/com/pingcap/tispark/partition/PartitionNewCollationSuite.scala Show resolved Hide resolved
xuanyu66 and others added 2 commits October 12, 2022 18:39
@xuanyu66 @github-actions
Update core/src/test/scala/com/pingcap/tispark/partition/PartitionBas…
eac8333 
…eSuite.scala

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@xuanyu66 @github-actions
Update core/src/test/scala/com/pingcap/tispark/partition/PartitionNew…
17589ab 
…CollationSuite.scala

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@xuanyu66
Copy link
Collaborator Author

/run-all-tests

@xuanyu66
Copy link
Collaborator Author

/run-all-tests

1 similar comment
@xuanyu66
Copy link
Collaborator Author

/run-all-tests

@zhangyangyu zhangyangyu added the needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 label Oct 13, 2022
@xuanyu66
Copy link
Collaborator Author

/run-all-tests

@xuanyu66
Copy link
Collaborator Author

/run-all-tests

1 similar comment
@xuanyu66
Copy link
Collaborator Author

/run-all-tests

@shiyuhang0
Copy link
Member

/run-all-tests

@xuanyu66
Copy link
Collaborator Author

/run-all-tests

@xuanyu66
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c8a865f

@ti-chi-bot ti-chi-bot merged commit 8632ad3 into master Oct 14, 2022
@ti-srebot
Copy link
Collaborator

cherry pick to release-release failed

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 14, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2570.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Oct 14, 2022
@xuanyu66 @ti-chi-bot
This is an automated cherry-pick of pingcap#2565
c9c771b 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Oct 17, 2022
@ti-chi-bot
Partition write support new collations (#2565) (#2570)
9b22435
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@xuanyu66
Partition write support new collations (pingcap#2565)
0fbedeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@Daemonxiao Daemonxiao Daemonxiao approved these changes

@shiyuhang0 shiyuhang0 shiyuhang0 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xuanyu66 @ti-chi-bot @shiyuhang0 @ti-srebot @Daemonxiao @zhangyangyu