New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update R/Python/core/tikv-client modules to RC1 #263
Conversation
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
* | ||
* @param tiSession TiSession used for selecting statistics information from TiKV | ||
*/ | ||
* Manager class for maintaining table statistics information cache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidentally introduced by scala formatter.
/run-all-tests |
PTAL @ilovesoup @birdstorm |
python/setup.py
Outdated
@@ -2,7 +2,7 @@ | |||
setup( | |||
name = 'pytispark', | |||
packages = ['pytispark'], | |||
version = '0.1.3', | |||
version = '1.0.0-RC1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be 1.0.0-RC1
or 1.0-RC1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw both on Pypi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The former could do more fined grained version control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we generally do not modify this module...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Python
,R
module.1.0-RC1