Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix json mapping issue #264

Merged
merged 1 commit into from Mar 12, 2018
Merged

Fix json mapping issue #264

merged 1 commit into from Mar 12, 2018

Conversation

Novemser
Copy link
Contributor

As a workaround, we temporarily map json to String type, it lacks decoding logic.

@sre-bot
Copy link
Contributor

sre-bot commented Mar 12, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

ilovesoup
ilovesoup approved these changes Mar 12, 2018
View reviewed changes
Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine for emergency fix but we might consider json to String first if not full support.

@ilovesoup ilovesoup merged commit 5ce1350 into master Mar 12, 2018
@ilovesoup ilovesoup deleted the fix_json_mapping branch March 12, 2018 14:38
@Novemser Novemser mentioned this pull request Mar 13, 2018
Closed
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@Novemser @ilovesoup
Map json to String (pingcap#264)
dd8fd54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilovesoup ilovesoup ilovesoup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Novemser @sre-bot @ilovesoup