Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry when store is down in high layer (#2710) #2714

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2710

What problem does this PR solve?

#2705

What is changed and how it works?

  1. when the store is unreachable or null, invalid cache and retry.

This enhancement will fix this situation: voter down and TiSpark fail

  1. catch the exception thrown by splitrange and retry

This enhancement will fix this situation: pd leader down and the region get from pd will be null then an exception will be thrown. According to the implementation of client-java, the switch leader needs to get members from pd, when it requests the down pd, it takes spark.tispark.grpc.timeout_in_sec(180s in default)*2 to retry, which may block the leader switch for spark.tispark.grpc.timeout_in_sec(180s in default)*2 s

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 30, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shiyuhang0
  • zhangyangyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@shiyuhang0
Copy link
Member

/run-all-tests

1 similar comment
@shiyuhang0
Copy link
Member

/run-all-tests

@shiyuhang0
Copy link
Member

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 31, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 64b45e2

@ti-chi-bot ti-chi-bot bot merged commit 9560247 into pingcap:release-3.2 May 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants