Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix collection is empty during region pre split #808

Merged
merged 4 commits into from Jun 10, 2019
Merged

fix collection is empty during region pre split #808

merged 4 commits into from Jun 10, 2019

Conversation

zhexuany
Copy link
Contributor

@zhexuany zhexuany commented Jun 10, 2019 •
edited

In this PR, we propose only perform region pre-split if RDD after sampled, is not empty.

This PR closes #773

@zhexuany zhexuany requested a review from birdstorm June 10, 2019 06:21
birdstorm
birdstorm approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

birdstorm
birdstorm suggested changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format

@zhexuany
Copy link
Contributor Author

/run-all-tests

birdstorm
birdstorm approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@birdstorm
Copy link
Contributor

/run-all-tests

1 similar comment
@zhexuany
Copy link
Contributor Author

/run-all-tests

@zhexuany
Copy link
Contributor Author

/run-all-tests tikv=v2.1.9 tidb=v2.1.9 pd=v2.1.9

@zhexuany
Copy link
Contributor Author

/run-all-tests tikv=v2.1.9 tidb=v2.1.9 pd=v2.1.9

@zhexuany zhexuany merged commit 913e400 into pingcap:master Jun 10, 2019
@zhexuany zhexuany deleted the fix_collection_being_empty_when_region_pre_split branch June 10, 2019 09:50
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
fix collection is empty during region pre split (pingcap#808)
07d8487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birdstorm birdstorm birdstorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enableRegionPreSplit throws Exception
2 participants
@zhexuany @birdstorm