Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the config 'runAsDaemon' from tiflash.toml #1673

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

hehechen
Copy link
Contributor

What problem does this PR solve?

#1671

What is changed and how it works?

Check the TiFlash version, remove the runAsDaemon config if TiFlash is in new version(>=v5.4.0) or the nightly version.

Check List

Tests

  • Unit test
  • Integration test

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 14, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2021

Codecov Report

Merging #1673 (ae3b6b6) into master (5eb7abf) will increase coverage by 17.55%.
The diff coverage is 31.82%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1673       +/-   ##
===========================================
+ Coverage   14.82%   32.36%   +17.55%     
===========================================
  Files         152      266      +114     
  Lines       18743    32057    +13314     
===========================================
+ Hits         2777    10375     +7598     
- Misses      15449    20212     +4763     
- Partials      517     1470      +953     
Flag Coverage Δ
dm 24.94% <0.00%> (?)
playground 12.91% <31.82%> (?)
tiup 14.81% <0.00%> (-0.01%) ⬇️
unittest ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/tiflash.go 0.00% <0.00%> (ø)
components/playground/instance/tiflash_config.go 70.59% <54.55%> (ø)
components/playground/instance/tiflash.go 55.56% <100.00%> (ø)
pkg/cluster/task/download.go 76.92% <0.00%> (ø)
pkg/cluster/task/install_package.go 45.83% <0.00%> (ø)
pkg/cluster/task/tls.go 0.00% <0.00%> (ø)
pkg/cluster/task/limits.go 0.00% <0.00%> (ø)
pkg/cluster/ansible/service.go 0.00% <0.00%> (ø)
pkg/cluster/task/mkdir.go 61.76% <0.00%> (ø)
pkg/cluster/manager/exec.go 60.76% <0.00%> (ø)
... and 181 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eb7abf...ae3b6b6. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 15, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ae3b6b6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 15, 2021
@pingcap pingcap deleted a comment from ti-chi-bot Dec 15, 2021
@AstroProfundis AstroProfundis added this to the v1.9.0 milestone Dec 15, 2021
@ti-chi-bot ti-chi-bot merged commit 3523106 into pingcap:master Dec 15, 2021
@hehechen hehechen deleted the tiflash_config branch December 15, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants