Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: deduplicate the check result #1737

Merged
merged 4 commits into from
Jan 26, 2022
Merged

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Jan 21, 2022

What problem does this PR solve?

close #1724

What is changed and how it works?

Use SetString to remove duplicate messages

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Code changes

Side effects

Related changes

Release notes:

NONE

@srstack srstack self-assigned this Jan 21, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022

Codecov Report

Merging #1737 (e626e28) into master (d2e2b40) will increase coverage by 21.15%.
The diff coverage is 93.10%.

❗ Current head e626e28 differs from pull request most recent head 23ebb9e. Consider uploading reports for the commit 23ebb9e to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1737       +/-   ##
===========================================
+ Coverage   24.43%   45.58%   +21.15%     
===========================================
  Files         277      303       +26     
  Lines       31461    34353     +2892     
===========================================
+ Hits         7686    15659     +7973     
+ Misses      22923    16831     -6092     
- Partials      852     1863     +1011     
Flag Coverage Δ
cluster 28.96% <0.00%> (?)
dm 24.72% <0.00%> (?)
playground 12.73% <ø> (?)
tiup 14.53% <ø> (-0.02%) ⬇️
unittest 21.40% <93.10%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/check.go 5.28% <93.10%> (+5.28%) ⬆️
pkg/repository/store/txn.go 56.91% <0.00%> (-2.13%) ⬇️
pkg/logger/debug.go 16.67% <0.00%> (ø)
components/playground/instance/process.go 81.97% <0.00%> (ø)
components/playground/instance/tikv.go 63.24% <0.00%> (ø)
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
pkg/cluster/operation/pd_member.go 0.00% <0.00%> (ø)
components/dm/task/update_dm_meta.go 87.76% <0.00%> (ø)
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
pkg/cluster/operation/download.go 33.33% <0.00%> (ø)
... and 186 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e2b40...23ebb9e. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 26, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 23ebb9e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2022
@ti-chi-bot ti-chi-bot merged commit 5a7693d into pingcap:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster: check results are duplicated
4 participants