Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: try to disable swap when check --apply #1803

Merged
merged 5 commits into from
Mar 28, 2022

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Close #1767

What is changed and how it works?

Support disabling swap (as described in doc) by setting vm.swappiness = 0 and swapoff to ensure all data already in the swap memory are swapped out.

@AstroProfundis AstroProfundis self-assigned this Mar 22, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from srstack March 22, 2022 08:09
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 22, 2022
@AstroProfundis AstroProfundis added this to the v1.10.0 milestone Mar 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #1803 (767fe24) into master (70dc546) will increase coverage by 27.54%.
The diff coverage is 100.00%.

❗ Current head 767fe24 differs from pull request most recent head 0be199c. Consider uploading reports for the commit 0be199c to get more accurate results

@@             Coverage Diff             @@
##           master    #1803       +/-   ##
===========================================
+ Coverage   24.31%   51.85%   +27.54%     
===========================================
  Files         277      303       +26     
  Lines       31763    34663     +2900     
===========================================
+ Hits         7723    17974    +10251     
+ Misses      23182    14576     -8606     
- Partials      858     2113     +1255     
Flag Coverage Δ
cluster 41.19% <100.00%> (?)
dm 18.89% <0.00%> (?)
unittest 21.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/check.go 68.79% <100.00%> (+64.19%) ⬆️
pkg/cluster/operation/check.go 48.51% <100.00%> (ø)
components/playground/instance/tikv.go 63.24% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
components/playground/instance/tiflash_config.go 72.22% <0.00%> (ø)
components/playground/instance/process.go 92.31% <0.00%> (ø)
pkg/logger/audit.go 57.69% <0.00%> (ø)
pkg/cluster/operation/action.go 62.53% <0.00%> (ø)
pkg/logger/debug.go 16.67% <0.00%> (ø)
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
... and 207 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70dc546...0be199c. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2022
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0be199c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 28, 2022
@ti-chi-bot ti-chi-bot merged commit 392f0ae into pingcap:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can --apply support swap fix
5 participants