Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: support check timezone #1890

Merged
merged 3 commits into from
May 26, 2022
Merged

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented May 20, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 20, 2022
@nexustar nexustar added this to the v1.10.0 milestone May 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #1890 (18019be) into master (956b072) will increase coverage by 23.53%.
The diff coverage is 0.00%.

❗ Current head 18019be differs from pull request most recent head bb0abb3. Consider uploading reports for the commit bb0abb3 to get more accurate results

@@             Coverage Diff             @@
##           master    #1890       +/-   ##
===========================================
+ Coverage   23.95%   47.49%   +23.53%     
===========================================
  Files         281      307       +26     
  Lines       32504    35454     +2950     
===========================================
+ Hits         7786    16836     +9050     
+ Misses      23848    16632     -7216     
- Partials      870     1986     +1116     
Flag Coverage Δ
cluster 32.95% <0.00%> (?)
dm 24.41% <0.00%> (?)
playground 12.91% <ø> (?)
tiup 14.45% <ø> (ø)
unittest 21.03% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/check.go 5.13% <0.00%> (+0.60%) ⬆️
pkg/cluster/operation/check.go 0.00% <0.00%> (ø)
pkg/cluster/task/check.go 0.00% <0.00%> (ø)
components/playground/instance/process.go 92.31% <0.00%> (ø)
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
pkg/logger/debug.go 16.67% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
pkg/cluster/operation/action.go 61.38% <0.00%> (ø)
pkg/logger/logger.go 100.00% <0.00%> (ø)
components/playground/instance/tidb.go 81.25% <0.00%> (ø)
... and 194 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956b072...bb0abb3. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 26, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bb0abb3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2022
@ti-chi-bot ti-chi-bot merged commit bda2367 into pingcap:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster check support to check the timezone of the nodes
4 participants