Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc rolling upgrade remove status check to prevent false detection. #1996

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Jul 26, 2022

What problem does this PR solve?

What is changed and how it works?

cdc prerestart and postrestart method, remove status check, since after the instance restart, it would cost a few seconds to be available.

  • this prevent false detect that a new start cdc instance is down, since it will be available just a few seconds later, around 3 ~ 5s seconds.
  • When all cdc instance is down, for upgrade / scale-in, this would cost a little longer time to guarantee that the instance is down now, which is acceptable.
  • adjust the timout for get capture open api to 10s, this should be long enough.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  • Deploy 2 cdc capture, restart the first one, the second one should perform the prerestart and postrestart as expected.

Code changes

Side effects

Related changes

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 26, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2022
@nexustar
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6e9c153

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 27, 2022
@ti-chi-bot ti-chi-bot merged commit e8fe110 into pingcap:master Jul 27, 2022
@nexustar nexustar added this to the v1.11.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants