-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: add support for displaying the grafana URLs in JSON output. #2041
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportBase: 47.87% // Head: 46.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2041 +/- ##
==========================================
- Coverage 47.87% 46.39% -1.47%
==========================================
Files 313 313
Lines 36536 37207 +671
==========================================
- Hits 17489 17262 -227
- Misses 16936 17709 +773
- Partials 2111 2236 +125
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/cc @AstroProfundis PTAL |
@onlyacat: GitHub didn't allow me to request PR reviews from the following users: PTAL. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I remember only first Grafana is used cc @AstroProfundis |
Yes. Only the first Grafana in topology with the literal order is used. Other Grafana instances should also be accessible but they all use the same datasource which is the first Prometheus in topology with the literal order. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c3f87be
|
What problem does this PR solve?
close #2040
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: