Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: add support for displaying the grafana URLs in JSON output. #2041

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

onlyacat
Copy link
Contributor

@onlyacat onlyacat commented Sep 15, 2022

What problem does this PR solve?

close #2040

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2022
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 15, 2022
@onlyacat onlyacat marked this pull request as ready for review September 15, 2022 06:33
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Base: 47.87% // Head: 46.39% // Decreases project coverage by -1.47% ⚠️

Coverage data is based on head (c3f87be) compared to base (d19f3a2).
Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2041      +/-   ##
==========================================
- Coverage   47.87%   46.39%   -1.47%     
==========================================
  Files         313      313              
  Lines       36536    37207     +671     
==========================================
- Hits        17489    17262     -227     
- Misses      16936    17709     +773     
- Partials     2111     2236     +125     
Flag Coverage Δ
tiup 16.17% <ø> (+2.28%) ⬆️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/display.go 49.31% <40.00%> (+2.81%) ⬆️
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-76.19%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/crypto/rand/passwd.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/telemetry/node_info.go 0.00% <0.00%> (-70.73%) ⬇️
pkg/utils/error.go 0.00% <0.00%> (-64.29%) ⬇️
components/dm/ansible/import.go 0.00% <0.00%> (-61.28%) ⬇️
pkg/telemetry/scrub.go 12.31% <0.00%> (-60.00%) ⬇️
pkg/cluster/executor/local.go 0.00% <0.00%> (-59.38%) ⬇️
... and 114 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@onlyacat
Copy link
Contributor Author

/cc @AstroProfundis PTAL

@ti-chi-bot
Copy link
Member

@onlyacat: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @AstroProfundis PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nexustar
Copy link
Collaborator

I remember only first Grafana is used cc @AstroProfundis

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 13, 2022
@AstroProfundis
Copy link
Contributor

I remember only first Grafana is used cc @AstroProfundis

Yes. Only the first Grafana in topology with the literal order is used.

Other Grafana instances should also be accessible but they all use the same datasource which is the first Prometheus in topology with the literal order.

@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c3f87be

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 17, 2022
@ti-chi-bot ti-chi-bot merged commit 9e2e464 into pingcap:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Grafana URL output in json format
6 participants