Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version 1.12.1 #2176

Merged
merged 1 commit into from
Apr 13, 2023
Merged

bump version 1.12.1 #2176

merged 1 commit into from
Apr 13, 2023

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 13, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kaaaaaaang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +25.24 🎉

Comparison is base (f7195cf) 25.51% compared to head (8981526) 50.75%.

❗ Current head 8981526 differs from pull request most recent head 09d2d4e. Consider uploading reports for the commit 09d2d4e to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2176       +/-   ##
===========================================
+ Coverage   25.51%   50.75%   +25.24%     
===========================================
  Files         290      317       +27     
  Lines       30357    33572     +3215     
===========================================
+ Hits         7743    17037     +9294     
+ Misses      21746    14488     -7258     
- Partials      868     2047     +1179     
Flag Coverage Δ
tiup 16.01% <ø> (ø)
unittest 22.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 206 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2023
@kaaaaaaang
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 09d2d4e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2023
@ti-chi-bot ti-chi-bot merged commit f4dae70 into pingcap:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants