Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress: Add option to add error detail #2203

Merged
merged 5 commits into from
Jun 13, 2023
Merged

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented May 25, 2023

What problem does this PR solve?

$ go test -v
=== RUN   TestExampleOutput
Prefix ... Done
Prefix ... Error: expected failure
--- PASS: TestExampleOutput (8.00s)
PASS
ok  	github.com/pingcap/tiup/pkg/tui/progress	8.004s

This could be helpful to add more detail to Clinic:
image

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 25, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from breezewish and srstack May 25, 2023 21:02
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: +0.41 🎉

Comparison is base (ea3af77) 46.30% compared to head (526816c) 46.71%.

❗ Current head 526816c differs from pull request most recent head e378d2e. Consider uploading reports for the commit e378d2e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2203      +/-   ##
==========================================
+ Coverage   46.30%   46.71%   +0.41%     
==========================================
  Files         319      320       +1     
  Lines       33618    33670      +52     
==========================================
+ Hits        15565    15726     +161     
+ Misses      16155    15999     -156     
- Partials     1898     1945      +47     
Flag Coverage Δ
cluster 32.37% <40.00%> (-2.86%) ⬇️
dm 19.62% <40.00%> (?)
playground 15.72% <40.00%> (-<0.01%) ⬇️
tiup 15.94% <0.00%> (-<0.01%) ⬇️
unittest 22.67% <0.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/tui/progress/display_props.go 0.00% <ø> (ø)
pkg/tui/progress/single_bar.go 82.11% <40.00%> (-2.68%) ⬇️

... and 65 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 6, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 6, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-06 15:15:33.204766197 +0000 UTC m=+17625.049400795: ☑️ agreed by srstack.
  • 2023-06-06 15:33:30.510699381 +0000 UTC m=+18702.355333983: ✖️🔁 reset by srstack.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2023

New changes are detected. LGTM label has been removed.

@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang, srstack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 13, 2023
@kaaaaaaang kaaaaaaang added this to the 1.13.0 milestone Jun 13, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2023

@dveeden: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@kaaaaaaang kaaaaaaang merged commit 7c46bd2 into pingcap:master Jun 13, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants