Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix not use manage_host when connect to pd/cdc #2206

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Jun 2, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested review from breezewish and srstack June 2, 2023 13:51
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 2, 2023
@nexustar nexustar changed the title ccccccugbjhtvcjchbbgfbndtjbbnrlbgkhvvelbrceicluster: fix not use manage_host when connect to pd/cdc cluster: fix not use manage_host when connect to pd/cdc Jun 2, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 2, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023

Codecov Report

Patch coverage: 61.11% and project coverage change: -0.27 ⚠️

Comparison is base (4e49a53) 56.26% compared to head (b3d32dc) 55.99%.

❗ Current head b3d32dc differs from pull request most recent head 32412a3. Consider uploading reports for the commit 32412a3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2206      +/-   ##
==========================================
- Coverage   56.26%   55.99%   -0.27%     
==========================================
  Files         320      320              
  Lines       33606    33609       +3     
==========================================
- Hits        18907    18817      -90     
- Misses      12454    12545      +91     
- Partials     2245     2247       +2     
Flag Coverage Δ
cluster 44.97% <61.76%> (-0.32%) ⬇️
dm 26.07% <2.86%> (-0.01%) ⬇️
playground 15.75% <0.00%> (-0.02%) ⬇️
tiup 16.00% <0.00%> (-0.03%) ⬇️
unittest 22.70% <2.94%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/playground.go 48.69% <0.00%> (-0.32%) ⬇️
pkg/cluster/manager/display.go 50.73% <0.00%> (+0.33%) ⬆️
pkg/cluster/operation/upgrade.go 47.14% <0.00%> (ø)
pkg/cluster/spec/tikv_cdc.go 48.50% <0.00%> (+0.57%) ⬆️
pkg/cluster/spec/cdc.go 57.67% <66.67%> (-0.53%) ⬇️
pkg/cluster/spec/pd.go 66.43% <66.67%> (-0.49%) ⬇️
pkg/cluster/spec/spec.go 83.33% <76.92%> (-0.28%) ⬇️
components/dm/command/scale_in.go 59.48% <100.00%> (ø)
pkg/cluster/operation/scale_in.go 49.53% <100.00%> (-5.33%) ⬇️
pkg/cluster/spec/tiflash.go 68.50% <100.00%> (-0.76%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 5, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang, srstack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-02 14:43:58.973014319 +0000 UTC m=+13825.245987102: ☑️ agreed by srstack.
  • 2023-06-02 14:44:06.286926168 +0000 UTC m=+13832.559898953: ✖️🔁 reset by srstack.
  • 2023-06-05 07:45:42.99980554 +0000 UTC m=+247929.272778324: ☑️ agreed by kaaaaaaang.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 5, 2023
@kaaaaaaang
Copy link
Collaborator

/merge

@ti-chi-bot ti-chi-bot bot merged commit 9fec88b into pingcap:master Jun 5, 2023
18 checks passed
@kaaaaaaang kaaaaaaang added this to the 1.12.3 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

etcd request not through the manage ip and port
4 participants