Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tiup uninstall check component exists #2209

Merged
merged 4 commits into from
Jun 13, 2023

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Jun 6, 2023

What problem does this PR solve?

close #2208

tiup uninstall tidb:v20.1.0                             
Error: component `tidb` is not installed, please use `tiup list tidb` to check
tiup uninstall noexits:v1.0.0                          
Error: component `noexits` is not installed, please use `tiup list noexits` to check

What is changed and how it works?

add check

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested review from breezewish and nexustar June 6, 2023 15:13
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: +9.69 🎉

Comparison is base (ea3af77) 46.30% compared to head (b36fe1d) 55.99%.

❗ Current head b36fe1d differs from pull request most recent head 43f601b. Consider uploading reports for the commit 43f601b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2209      +/-   ##
==========================================
+ Coverage   46.30%   55.99%   +9.69%     
==========================================
  Files         319      320       +1     
  Lines       33618    33674      +56     
==========================================
+ Hits        15565    18854    +3289     
+ Misses      16155    12564    -3591     
- Partials     1898     2256     +358     
Flag Coverage Δ
cluster 44.98% <ø> (+9.75%) ⬆️
dm 26.04% <ø> (?)
playground 15.72% <ø> (ø)
tiup 15.97% <25.00%> (+0.02%) ⬆️
unittest 22.67% <0.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/uninstall.go 66.67% <25.00%> (-4.58%) ⬇️

... and 119 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 13, 2023
@kaaaaaaang
Copy link
Collaborator

/merge

1 similar comment
@kaaaaaaang
Copy link
Collaborator

/merge

@kaaaaaaang kaaaaaaang merged commit 72ec0ac into pingcap:master Jun 13, 2023
17 of 18 checks passed
@kaaaaaaang kaaaaaaang added this to the 1.12.3 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uninstall does't check if the component exists
3 participants