Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix cannot start tiflash above 7.1.0 #2230

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

zanmato1984
Copy link
Contributor

@zanmato1984 zanmato1984 commented Jul 17, 2023

What problem does this PR solve?

Close #2229

What is changed and how it works?

  1. Include "nightly" in version check for tiflash that doesn't require tcp port.
  2. Change ready detection to use service port rather than tcp port.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Deploy v7.1.0/v7.2.0/nightly cluster. Before this patch, starting cluster failed at tiflash component. After this patch, starting cluster succeeded.

Code changes

  • None

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

Release notes:

Fix the issue that cluster start failure caused by tiflash checking for tcp port ready.

@ti-chi-bot ti-chi-bot bot requested review from nexustar and srstack July 17, 2023 06:16
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.84 ⚠️

Comparison is base (a7aa964) 56.00% compared to head (5d813c0) 53.16%.

❗ Current head 5d813c0 differs from pull request most recent head 78ccf34. Consider uploading reports for the commit 78ccf34 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2230      +/-   ##
==========================================
- Coverage   56.00%   53.16%   -2.84%     
==========================================
  Files         320      320              
  Lines       33795    33795              
==========================================
- Hits        18926    17967     -959     
- Misses      12601    13660    +1059     
+ Partials     2268     2168     -100     
Flag Coverage Δ
cluster 40.24% <0.00%> (-4.89%) ⬇️
dm 25.98% <0.00%> (-0.05%) ⬇️
playground 15.78% <0.00%> (-0.02%) ⬇️
tiup 15.93% <0.00%> (ø)
unittest 22.64% <0.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/tiflash.go 44.75% <0.00%> (-24.23%) ⬇️
pkg/tidbver/tidbver.go 71.19% <0.00%> (-18.64%) ⬇️

... and 59 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 17, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-17 08:29:35.265808708 +0000 UTC m=+925467.036147414: ☑️ agreed by kaaaaaaang.

@ti-chi-bot ti-chi-bot bot added the approved label Jul 17, 2023
@kaaaaaaang kaaaaaaang changed the title cluster: fix tiflash tcp port still open for nightly and breaking the ready detection cluster: fix cannot start tiflash for 7.1.0 + Jul 17, 2023
@kaaaaaaang kaaaaaaang changed the title cluster: fix cannot start tiflash for 7.1.0 + cluster: fix cannot start tiflash above 7.1.0+ Jul 17, 2023
@kaaaaaaang kaaaaaaang changed the title cluster: fix cannot start tiflash above 7.1.0+ cluster: fix cannot start tiflash above 7.1.0 Jul 17, 2023
@ti-chi-bot ti-chi-bot bot merged commit aa695f3 into pingcap:master Jul 17, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiup failed to start cluster for Tiflash port 9000 not started
3 participants