Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix node filter on exec #2251

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@nexustar nexustar added this to the 1.13.0 milestone Aug 15, 2023
@ti-chi-bot ti-chi-bot bot requested a review from breezewish August 15, 2023 16:48
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.16% ⚠️

Comparison is base (600390f) 56.14% compared to head (1b0561c) 55.97%.

❗ Current head 1b0561c differs from pull request most recent head db8afed. Consider uploading reports for the commit db8afed to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2251      +/-   ##
==========================================
- Coverage   56.14%   55.97%   -0.16%     
==========================================
  Files         320      320              
  Lines       33866    33866              
==========================================
- Hits        19011    18956      -55     
- Misses      12585    12640      +55     
  Partials     2270     2270              
Flag Coverage Δ
cluster 44.83% <100.00%> (-0.17%) ⬇️
dm 25.69% <100.00%> (-0.05%) ⬇️
playground 15.73% <ø> (-0.02%) ⬇️
tiup 15.88% <ø> (-0.02%) ⬇️
unittest 22.66% <0.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/cluster/manager/exec.go 68.35% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 16, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-16 02:48:30.407604696 +0000 UTC m=+685674.956620678: ☑️ agreed by srstack.

@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang, srstack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 16, 2023
@ti-chi-bot ti-chi-bot bot merged commit e450cb3 into pingcap:master Aug 16, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup cluster exec no result when using manage_host
4 participants