Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: not abort destroy if cannot delete files #2256

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Aug 18, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested a review from breezewish August 18, 2023 09:38
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Patch coverage: 71.43% and project coverage change: +30.61% 🎉

Comparison is base (0a60bc3) 25.47% compared to head (7ac4a30) 56.07%.

❗ Current head 7ac4a30 differs from pull request most recent head 60a4c34. Consider uploading reports for the commit 60a4c34 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2256       +/-   ##
===========================================
+ Coverage   25.47%   56.07%   +30.61%     
===========================================
  Files         290      320       +30     
  Lines       30528    33873     +3345     
===========================================
+ Hits         7775    18994    +11219     
+ Misses      21881    12611     -9270     
- Partials      872     2268     +1396     
Flag Coverage Δ
cluster 44.94% <71.43%> (?)
dm 25.73% <71.43%> (?)
playground 15.74% <ø> (?)
tiup 15.87% <ø> (ø)
unittest 22.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/cluster/operation/destroy.go 60.89% <71.43%> (ø)

... and 231 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 18, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-18 13:56:43.050859718 +0000 UTC m=+898567.599875702: ☑️ agreed by kaaaaaaang.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit cc5d0c2 into pingcap:master Aug 18, 2023
18 checks passed
@kaaaaaaang kaaaaaaang added this to the 1.13.0 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show warning and continue if cannot delete data dir when destroy/scale-in instead of error and exit
3 participants