Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: support use different component versions #2264

Merged
merged 11 commits into from
Nov 7, 2023

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Aug 24, 2023

What problem does this PR solve?

What is changed and how it works?

  • user could fix version of component when upgrade
  • component that has fixed version will not use cluster version when next time upgrade

image
image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested a review from breezewish August 24, 2023 11:07
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (1e2e855) 55.44% compared to head (c492915) 55.40%.

❗ Current head c492915 differs from pull request most recent head a15238a. Consider uploading reports for the commit a15238a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2264      +/-   ##
==========================================
- Coverage   55.44%   55.40%   -0.04%     
==========================================
  Files         326      325       -1     
  Lines       34478    34694     +216     
==========================================
+ Hits        19116    19221     +105     
- Misses      13072    13174     +102     
- Partials     2290     2299       +9     
Flag Coverage Δ
cluster 44.73% <71.76%> (+0.04%) ⬆️
dm 25.47% <32.27%> (+<0.01%) ⬆️
playground 15.26% <0.00%> (-0.10%) ⬇️
tiup 15.57% <0.00%> (-0.10%) ⬇️
unittest 22.32% <10.29%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
components/cluster/command/display.go 46.58% <100.00%> (+0.74%) ⬆️
components/cluster/command/root.go 46.21% <100.00%> (ø)
components/cluster/command/upgrade.go 80.65% <100.00%> (+13.98%) ⬆️
components/dm/command/root.go 56.72% <100.00%> (ø)
components/dm/command/upgrade.go 57.14% <100.00%> (ø)
pkg/cluster/manager/check.go 69.41% <100.00%> (ø)
pkg/cluster/manager/deploy.go 68.49% <100.00%> (-0.11%) ⬇️
pkg/cluster/manager/manager.go 68.75% <ø> (-0.18%) ⬇️
pkg/cluster/spec/bindversion.go 30.77% <ø> (-46.15%) ⬇️
pkg/cluster/spec/instance.go 65.87% <100.00%> (+0.27%) ⬆️
... and 22 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 25, 2023

@nexustar: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 17, 2023
@kaaaaaaang kaaaaaaang force-pushed the component_version branch 3 times, most recently from 9e0a52f to eccad5f Compare September 17, 2023 18:31
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 7, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-24 11:14:57.11264413 +0000 UTC m=+1407261.661660110: ☑️ agreed by srstack.
  • 2023-08-24 14:30:45.846929772 +0000 UTC m=+1419010.395945759: ✖️🔁 reset by nexustar.
  • 2023-11-07 10:00:38.485414627 +0000 UTC m=+3552036.072524757: ☑️ agreed by kaaaaaaang.

@kaaaaaaang kaaaaaaang added this to the v1.14.0 milestone Nov 7, 2023
@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit eb2f058 into pingcap:master Nov 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants