Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup: support run components without tiup #2265

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested a review from breezewish August 25, 2023 09:23
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 9547 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 25, 2023
@nexustar nexustar changed the title Support link tiup: support run components without tiup Aug 25, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Patch coverage: 22.37% and project coverage change: -0.07% ⚠️

Comparison is base (78092c0) 55.81% compared to head (17ff699) 55.74%.
Report is 1 commits behind head on master.

❗ Current head 17ff699 differs from pull request most recent head 12d9930. Consider uploading reports for the commit 12d9930 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2265      +/-   ##
==========================================
- Coverage   55.81%   55.74%   -0.07%     
==========================================
  Files         321      323       +2     
  Lines       34022    34096      +74     
==========================================
+ Hits        18989    19006      +17     
- Misses      12761    12817      +56     
- Partials     2272     2273       +1     
Flag Coverage Δ
tiup 15.90% <22.37%> (+0.03%) ⬆️
unittest 22.60% <33.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/environment/env.go 52.76% <8.82%> (-8.31%) ⬇️
cmd/unlink.go 23.08% <23.08%> (ø)
cmd/link.go 42.86% <42.86%> (ø)
cmd/root.go 48.67% <100.00%> (+0.46%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-25 09:37:07.454662657 +0000 UTC m=+1487792.003678645: ☑️ agreed by srstack.
  • 2023-08-25 11:04:32.604375336 +0000 UTC m=+1493037.153391320: ✖️🔁 reset by nexustar.
  • 2023-08-25 14:37:42.499412004 +0000 UTC m=+1505827.048427991: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/merge

@kaaaaaaang
Copy link
Collaborator

/lgtm

@kaaaaaaang kaaaaaaang merged commit 66cc9bd into pingcap:master Aug 25, 2023
17 of 18 checks passed
@kaaaaaaang kaaaaaaang added this to the 1.13.0 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants