Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: support tiproxy #2271

Merged
merged 7 commits into from
Oct 25, 2023
Merged

cluster: support tiproxy #2271

merged 7 commits into from
Oct 25, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Sep 5, 2023

What problem does this PR solve?

As title. Also fixed meta update for dashboard servers.

Ai0k3PhDFp

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

Suppor tiproxy for tiup cluster

@ti-chi-bot ti-chi-bot bot requested a review from breezewish September 5, 2023 05:44
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Attention: 194 lines in your changes are missing coverage. Please review.

Comparison is base (9e47d78) 55.88% compared to head (87a6dd8) 54.92%.

❗ Current head 87a6dd8 differs from pull request most recent head 8a2050f. Consider uploading reports for the commit 8a2050f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2271      +/-   ##
==========================================
- Coverage   55.88%   54.92%   -0.96%     
==========================================
  Files         324      326       +2     
  Lines       34167    34373     +206     
==========================================
- Hits        19093    18877     -216     
- Misses      12800    13214     +414     
- Partials     2274     2282       +8     
Flag Coverage Δ
cluster 43.74% <6.28%> (-1.14%) ⬇️
dm 25.44% <0.00%> (-0.26%) ⬇️
playground 15.53% <0.00%> (-0.28%) ⬇️
tiup 15.71% <0.00%> (-0.20%) ⬇️
unittest 22.43% <3.43%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/cluster/spec/spec.go 83.70% <100.00%> (+0.10%) ⬆️
pkg/cluster/spec/bindversion.go 76.92% <0.00%> (-13.99%) ⬇️
pkg/cluster/template/config/prometheus.go 82.00% <0.00%> (-2.54%) ⬇️
pkg/cluster/task/update_meta.go 75.41% <50.00%> (-8.94%) ⬇️
pkg/cluster/spec/monitoring.go 75.07% <16.67%> (-0.98%) ⬇️
pkg/cluster/template/scripts/tiproxy.go 0.00% <0.00%> (ø)
pkg/cluster/spec/tiproxy.go 2.94% <2.94%> (ø)

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 25, 2023
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-25 04:04:44.074399461 +0000 UTC m=+2407481.661509590: ☑️ agreed by srstack.
  • 2023-10-25 08:06:42.588115765 +0000 UTC m=+2422000.175225910: ✖️🔁 reset by xhebox.
  • 2023-10-25 08:56:35.854972541 +0000 UTC m=+2424993.442082671: ☑️ agreed by srstack.

@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 25, 2023
@ti-chi-bot ti-chi-bot bot merged commit 79d3011 into pingcap:master Oct 25, 2023
18 checks passed
@kaaaaaaang kaaaaaaang added this to the v1.14.0 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants