Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pd microservice component id #2272

Merged

Conversation

iosmanthus
Copy link
Contributor

What problem does this PR solve?

close #2270

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@ti-chi-bot ti-chi-bot bot requested a review from breezewish September 5, 2023 09:21
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 5, 2023

@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -3.07% ⚠️

Comparison is base (b1557f8) 43.44% compared to head (1447347) 40.36%.

❗ Current head 1447347 differs from pull request most recent head b5f5481. Consider uploading reports for the commit b5f5481 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2272      +/-   ##
==========================================
- Coverage   43.44%   40.36%   -3.07%     
==========================================
  Files         305      266      -39     
  Lines       33169    28795    -4374     
==========================================
- Hits        14408    11623    -2785     
+ Misses      17023    15559    -1464     
+ Partials     1738     1613     -125     
Flag Coverage Δ
tiup 15.88% <ø> (ø)
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 93 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 5, 2023

@JmPotato: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 6, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-06 06:08:52.37999865 +0000 UTC m=+2512096.929014622: ☑️ agreed by kaaaaaaang.

@iosmanthus
Copy link
Contributor Author

/merge

@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 6, 2023
@ti-chi-bot ti-chi-bot bot merged commit 2446193 into pingcap:master Sep 6, 2023
6 checks passed
@kaaaaaaang kaaaaaaang added this to the v1.13.1 milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

miss the component name in deploy directory
5 participants