Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scheduling service #2273

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Support scheduling service #2273

merged 5 commits into from
Oct 31, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 6, 2023

What problem does this PR solve?

Support scheduling service for tiup playground

What is changed and how it works?

Check List

Tests

  • Manual test

Release notes:

NONE

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot requested a review from breezewish September 6, 2023 06:40
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (b8fbc84) 55.53% compared to head (cb876b0) 55.44%.

❗ Current head cb876b0 differs from pull request most recent head 35e26e8. Consider uploading reports for the commit 35e26e8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2273      +/-   ##
==========================================
- Coverage   55.53%   55.44%   -0.08%     
==========================================
  Files         326      326              
  Lines       34413    34473      +60     
==========================================
+ Hits        19108    19113       +5     
- Misses      13024    13072      +48     
- Partials     2281     2288       +7     
Flag Coverage Δ
playground 15.45% <5.00%> (-0.04%) ⬇️
tiup 15.68% <ø> (ø)
unittest 22.43% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
components/playground/instance/instance.go 44.29% <0.00%> (ø)
components/playground/main.go 59.24% <50.00%> (+0.78%) ⬆️
components/playground/instance/pd.go 48.72% <0.00%> (-6.09%) ⬇️
components/playground/playground.go 44.10% <1.79%> (-1.91%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang kaaaaaaang added this to the v1.14.0 milestone Sep 6, 2023
@rleungx
Copy link
Member Author

rleungx commented Sep 18, 2023

/cc @lhy1024 @JmPotato

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 18, 2023

@rleungx: GitHub didn't allow me to request PR reviews from the following users: lhy1024, JmPotato.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @lhy1024 @JmPotato

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2023
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 25, 2023
@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Oct 25, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Oct 25, 2023
@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 31, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-25 10:04:34.55934891 +0000 UTC m=+2429072.146459058: ☑️ agreed by kaaaaaaang.
  • 2023-10-25 10:04:51.401561715 +0000 UTC m=+2429088.988671860: ✖️🔁 reset by ti-chi-bot[bot].
  • 2023-10-31 09:12:22.357604328 +0000 UTC m=+2944339.944714458: ☑️ agreed by kaaaaaaang.

@ti-chi-bot ti-chi-bot bot merged commit 1477739 into pingcap:master Oct 31, 2023
6 checks passed
@rleungx rleungx deleted the scheduling branch November 2, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants