Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new flag '--numa' to show numa in display command #2295

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

KanShiori
Copy link
Collaborator

What problem does this PR solve?

Close #2294

What is changed and how it works?

add a new flag '--numa' to show numa in display command.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. Deploy a new cluster.
  2. Display with '--numa' flag.
    image
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

add a new flag '--numa' to show numa in display command

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (79d3011) 55.55% compared to head (cbb9a94) 50.20%.

❗ Current head cbb9a94 differs from pull request most recent head 72337a9. Consider uploading reports for the commit 72337a9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2295      +/-   ##
==========================================
- Coverage   55.55%   50.20%   -5.35%     
==========================================
  Files         326      325       -1     
  Lines       34378    34410      +32     
==========================================
- Hits        19098    17274    -1824     
- Misses      12998    14869    +1871     
+ Partials     2282     2267      -15     
Flag Coverage Δ
cluster 44.50% <76.74%> (-0.13%) ⬇️
dm 25.46% <28.57%> (-0.04%) ⬇️
playground 15.48% <0.00%> (-0.04%) ⬇️
tiup 15.70% <0.00%> (-0.01%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
components/cluster/command/display.go 45.83% <100.00%> (+0.76%) ⬆️
pkg/cluster/spec/alertmanager.go 68.10% <100.00%> (+0.56%) ⬆️
pkg/cluster/spec/cdc.go 58.42% <100.00%> (-0.08%) ⬇️
pkg/cluster/spec/drainer.go 57.07% <100.00%> (+0.47%) ⬆️
pkg/cluster/spec/grafana.go 61.33% <100.00%> (-2.34%) ⬇️
pkg/cluster/spec/instance.go 65.60% <100.00%> (+0.56%) ⬆️
pkg/cluster/spec/monitoring.go 72.21% <100.00%> (-2.86%) ⬇️
pkg/cluster/spec/pd.go 67.02% <100.00%> (+0.23%) ⬆️
pkg/cluster/spec/pump.go 63.19% <100.00%> (-3.48%) ⬇️
pkg/cluster/spec/tidb.go 66.07% <100.00%> (+0.41%) ⬆️
... and 7 more

... and 55 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 31, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-31 06:16:52.278739601 +0000 UTC m=+2933809.865849731: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 31, 2023
@ti-chi-bot ti-chi-bot bot merged commit bdf6f26 into pingcap:master Oct 31, 2023
18 checks passed
@KanShiori KanShiori deleted the shiori/show-numa branch October 31, 2023 06:17
@kaaaaaaang kaaaaaaang added this to the v1.14.0 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup-cluster:support show numa node when display
3 participants