Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: fix tiproxy metrics addr #2299

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Nov 3, 2023

What problem does this PR solve?

Playground promtheus pulls wrong metric addresses for tiproxy.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

Fix tiproxy metrics on playground

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (721b065) 55.47% compared to head (7448ca0) 55.43%.

❗ Current head 7448ca0 differs from pull request most recent head 76a461b. Consider uploading reports for the commit 76a461b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2299      +/-   ##
==========================================
- Coverage   55.47%   55.43%   -0.04%     
==========================================
  Files         326      326              
  Lines       34479    34478       -1     
==========================================
- Hits        19125    19111      -14     
- Misses      13063    13075      +12     
- Partials     2291     2292       +1     
Flag Coverage Δ
playground 15.36% <61.90%> (-0.07%) ⬇️
tiup 15.67% <ø> (ø)
unittest 22.43% <0.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
components/playground/instance/instance.go 44.29% <100.00%> (ø)
components/playground/playground.go 44.00% <100.00%> (-0.10%) ⬇️
components/playground/monitor.go 76.67% <81.82%> (-4.39%) ⬇️
components/playground/instance/tiproxy.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 3, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 3, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-03 07:01:27.271763579 +0000 UTC m=+3195684.858873724: ☑️ agreed by kaaaaaaang.

@xhebox
Copy link
Collaborator Author

xhebox commented Nov 3, 2023

/approve

@kaaaaaaang
Copy link
Collaborator

/lgtm

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 3, 2023
@ti-chi-bot ti-chi-bot bot merged commit a07c4d7 into pingcap:master Nov 3, 2023
6 checks passed
@kaaaaaaang kaaaaaaang added this to the v1.14.0 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants